This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Make the 'optional' label unselectable #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to affect only some browsers (happens in Chrome, not in Firefox). When you double click a parameter name that is optional, the browser also selects the word 'optional'. This is pretty annoying when you want to double click and copy a property name, as the actually copied value becomes "propertyNameoptional". Assuming that no one actually needs to select the text inside the optional label, I figured this was the simplest solution to the problem. Open to other solutions.
|
On a related note, there's always a space appended before the
|
|
Thank you, this seems like a reasonable solution to the issue. As for the space, I removed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to affect only some browsers (happens in Chrome, not in Firefox). When you double click a parameter name that is optional, the browser also selects the word 'optional'. This is pretty annoying when you want to double click and copy a property name, as the actually copied value becomes "propertyNameoptional".
Assuming that no one actually needs to select the text inside the optional label, I figured this was the simplest solution to the problem. Open to other solutions.