Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed content warnings #13

Open
markhibberd opened this issue Nov 25, 2012 · 3 comments
Open

Mixed content warnings #13

markhibberd opened this issue Nov 25, 2012 · 3 comments

Comments

@markhibberd
Copy link
Member

There are content warnings for the social favicons - probably should be served up by us.

Ignoring API Gravatars as they will be updated soon, that is the last https error I can see.

@thomasdavis
Copy link
Member

sounds good, it's probably worth just reusing the icons off the homepage anyway

@RichardBarrett what do you think

@RichardBarrett
Copy link

What is this discussion about?

On 26 November 2012 11:20, Thomas Davis notifications@github.com wrote:

sounds good, it's probably worth just reusing the icons off the homepage
anyway

@RichardBarrett https://github.com/RichardBarrett what do you think


Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-10701709.

@thomasdavis
Copy link
Member

On the profile page, we are bringing the favicons directly from the websites. We are getting content warnings, I could try protocol relative links.

But does it make sense that maybe we should just reuse the social icon set on the home page, for social icons on a users profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants