Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the validation for input location #259

Closed
greyli opened this issue May 3, 2022 · 2 comments · Fixed by #397
Closed

Consider removing the validation for input location #259

greyli opened this issue May 3, 2022 · 2 comments · Fixed by #397
Assignees
Projects
Milestone

Comments

@greyli
Copy link
Member

greyli commented May 3, 2022

In the current implementation, if the user uses an unsupported input location in app.input(location=...), APIFlask will raise a ValueError.

Pros:

  • Allow users to create a custom location loader

Cons:

  • No error is raised if the user uses a bad location (typo)
@greyli greyli added this to the 1.1.0 milestone May 3, 2022
@greyli greyli added this to To do in 1.1 May 4, 2022
@greyli greyli removed this from the 1.1.0 milestone Jun 22, 2022
@greyli greyli removed this from To do in 1.1 Jun 22, 2022
@greyli greyli added this to To do in 1.2 Aug 13, 2022
@mmdbalkhi
Copy link
Member

Hello, I want to work on this, can you give me more information?

@greyli
Copy link
Member Author

greyli commented Jan 15, 2023

Just remove these lines and the related variable. Also, update tests and changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.2
To do
Development

Successfully merging a pull request may close this issue.

2 participants