Skip to content

Commit

Permalink
chore: update Node.js 18 -> 20 in all templates (#275)
Browse files Browse the repository at this point in the history
Not sure if we have some good test suite to make sure the
templates/SDK/Crawlee don't break down in Node 20. You know this random
crap likes to happen :)
  • Loading branch information
metalwarrior665 committed Apr 30, 2024
2 parents 3abbeeb + 5271eb4 commit 839f811
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion templates/js-bootstrap-cheerio-crawler/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# See https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
2 changes: 1 addition & 1 deletion templates/js-crawlee-cheerio/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
2 changes: 1 addition & 1 deletion templates/js-crawlee-playwright-chrome/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://crawlee.dev/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node-playwright-chrome:18
FROM apify/actor-node-playwright-chrome:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
2 changes: 1 addition & 1 deletion templates/js-crawlee-puppeteer-chrome/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://crawlee.dev/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node-puppeteer-chrome:18
FROM apify/actor-node-puppeteer-chrome:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
2 changes: 1 addition & 1 deletion templates/js-empty/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
2 changes: 1 addition & 1 deletion templates/js-langchain/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18
FROM apify/actor-node:20

RUN apk add g++ make py3-pip

Expand Down
2 changes: 1 addition & 1 deletion templates/js-start/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-bootstrap-cheerio-crawler/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://crawlee.dev/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18 AS builder
FROM apify/actor-node:20 AS builder

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand All @@ -19,7 +19,7 @@ COPY . ./
RUN npm run build

# Create final image
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-crawlee-cheerio/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://crawlee.dev/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18 AS builder
FROM apify/actor-node:20 AS builder

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand All @@ -19,7 +19,7 @@ COPY . ./
RUN npm run build

# Create final image
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-crawlee-playwright-chrome/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://crawlee.dev/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node-playwright-chrome:18 AS builder
FROM apify/actor-node-playwright-chrome:20 AS builder

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand All @@ -19,7 +19,7 @@ COPY --chown=myuser . ./
RUN npm run build

# Create final image
FROM apify/actor-node-playwright-chrome:18
FROM apify/actor-node-playwright-chrome:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-crawlee-puppeteer-chrome/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://crawlee.dev/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node-puppeteer-chrome:18 AS builder
FROM apify/actor-node-puppeteer-chrome:20 AS builder

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand All @@ -19,7 +19,7 @@ COPY --chown=myuser . ./
RUN npm run build

# Create final image
FROM apify/actor-node-puppeteer-chrome:18
FROM apify/actor-node-puppeteer-chrome:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-empty/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18 AS builder
FROM apify/actor-node:20 AS builder

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand All @@ -19,7 +19,7 @@ COPY . ./
RUN npm run build

# Create final image
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down
2 changes: 1 addition & 1 deletion templates/ts-playwright-test-runner/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM apify/actor-node-playwright:18-1.37.1
FROM apify/actor-node-playwright:20-1.37.1

COPY package*.json ./

Expand Down
4 changes: 2 additions & 2 deletions templates/ts-start/.actor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Specify the base Docker image. You can read more about
# the available images at https://docs.apify.com/sdk/js/docs/guides/docker-images
# You can also use any other image from Docker Hub.
FROM apify/actor-node:18 AS builder
FROM apify/actor-node:20 AS builder

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand All @@ -19,7 +19,7 @@ COPY . ./
RUN npm run build

# Create final image
FROM apify/actor-node:18
FROM apify/actor-node:20

# Copy just package.json and package-lock.json
# to speed up the build using Docker layer cache.
Expand Down

0 comments on commit 839f811

Please sign in to comment.