chore: mark built images as having browsers installed (#111)

Needed for apify/crawlee#2104
apify · Oct 2, 2023 · 5528fdd · 5528fdd
1 parent a2359ae
commit 5528fdd
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/node-playwright-chrome/Dockerfile b/node-playwright-chrome/Dockerfile
@@ -64,6 +64,9 @@ COPY --chown=myuser:myuser package.json main.js chrome_test.js start_xvfb_and_ru
 # Sets path to Chrome executable, this is used by Apify.launchPuppeteer()
 ENV APIFY_CHROME_EXECUTABLE_PATH=/usr/bin/google-chrome
 
+# Tell the crawlee cli that we already have browers installed, so it skips installing them
+ENV CRAWLEE_SKIP_BROWSER_INSTALL=1
+
 # Tell Node.js this is a production environemnt
 ENV NODE_ENV=production
 

diff --git a/node-playwright-firefox/Dockerfile b/node-playwright-firefox/Dockerfile
@@ -48,6 +48,9 @@ WORKDIR /home/myuser
 
 ENV PLAYWRIGHT_BROWSERS_PATH=/home/myuser/pw-browsers
 
+# Tell the crawlee cli that we already have browers installed, so it skips installing them
+ENV CRAWLEE_SKIP_BROWSER_INSTALL=1
+
 # Copy source code and xvfb script
 COPY --chown=myuser:myuser package.json main.js firefox_test.js start_xvfb_and_run_cmd.sh /home/myuser/
 

diff --git a/node-playwright-webkit/Dockerfile b/node-playwright-webkit/Dockerfile
@@ -44,6 +44,9 @@ WORKDIR /home/myuser
 
 ENV PLAYWRIGHT_BROWSERS_PATH=/home/myuser/pw-browsers
 
+# Tell the crawlee cli that we already have browers installed, so it skips installing them
+ENV CRAWLEE_SKIP_BROWSER_INSTALL=1
+
 # Copy source code and xvfb script
 COPY --chown=myuser:myuser package.json main.js webkit_test.js start_xvfb_and_run_cmd.sh /home/myuser/
 

diff --git a/node-playwright/Dockerfile b/node-playwright/Dockerfile
@@ -61,6 +61,9 @@ WORKDIR /home/myuser
 # Point playwright to the preincluded browsers - moving browsers around increases the image size a *lot*
 ENV PLAYWRIGHT_BROWSERS_PATH=/ms-playwright
 
+# Tell the crawlee cli that we already have browers installed, so it skips installing them
+ENV CRAWLEE_SKIP_BROWSER_INSTALL=1
+
 # Copy source code and xvfb script
 COPY --chown=myuser:myuser package.json main.js chrome_test.js start_xvfb_and_run_cmd.sh /home/myuser/
 

diff --git a/node-puppeteer-chrome/Dockerfile b/node-puppeteer-chrome/Dockerfile
@@ -72,6 +72,9 @@ COPY --chown=myuser:myuser package.json main.js puppeteer_*.js start_xvfb_and_ru
 # Sets path to Chrome executable, this is used by Apify.launchPuppeteer()
 ENV APIFY_CHROME_EXECUTABLE_PATH=/usr/bin/google-chrome
 
+# Tell the crawlee cli that we already have browers installed, so it skips installing them
+ENV CRAWLEE_SKIP_BROWSER_INSTALL=1
+
 # Tell Node.js this is a production environemnt
 ENV NODE_ENV=production