Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apify run --purge doesn't purge #545

Closed
jirimoravcik opened this issue Apr 3, 2024 · 5 comments · Fixed by #548
Closed

apify run --purge doesn't purge #545

jirimoravcik opened this issue Apr 3, 2024 · 5 comments · Fixed by #548
Assignees
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@jirimoravcik
Copy link
Member

apify run --purge doesn't purge, even tried with npx apify-cli@1.0.0-beta.42 run --purge

How to reproduce?
Run:

apify create
? Name of your new actor: purge-test
? Choose the programming language of your new actor: Python
? Choose a template for your new actor. Detailed information about the template will be shown in the next step. BeautifulSoup + HTTPX
? Do you want to install the following template?
 BeautifulSoup + HTTPX:
cd purge-test
apify run --purge

but now if you run the following command again:

apify run --purge

it won't scrape anything, because the purge didn't happen.

@jirimoravcik jirimoravcik added the bug Something isn't working. label Apr 3, 2024
@B4nan
Copy link
Member

B4nan commented Apr 4, 2024

Hmm, does the python SDK purge by default? It should.

cc @vdusek

@vdusek
Copy link
Contributor

vdusek commented Apr 4, 2024

Hmm, does the python SDK purge by default? It should.

I don't think so. I am used to running apify run --purge.

@B4nan
Copy link
Member

B4nan commented Apr 4, 2024

Hmm, this was the old sdk v2 behavior, I don't recall if python SDK was released before or after crawlee, but we changed this with crawlee and SDK v3 - the storages are purged by default unless you opt-out of it via env var (which the CLI sets via --no-purge). Another thing we need to fix with the upcoming major versions.

cc @vladfrangu, we should add the explicit purging for python projects (to both 0.x and 1.0) as it will take some time for the python tooling to catch up.

@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 4, 2024
@B4nan
Copy link
Member

B4nan commented Apr 4, 2024

Opened apify/crawlee-python#87 to track the change on python's end.

@vladfrangu
Copy link
Member

Fix for this is

  • PR'd for cli@beta
  • Released for stable (0.19.4) (because I tested it locally and indeed, it works now!)

vladfrangu added a commit that referenced this issue Apr 9, 2024
Closes #545 

Will push the same fix to the 0.19.x branch and release (I've tested it
locally and it works as intended now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants