Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): Open actor detail after successful apify push #353

Merged
merged 3 commits into from
Apr 3, 2023
Merged

feat(app): Open actor detail after successful apify push #353

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72c4dd4
feat(app): Open actor detail after successful apify push
HonzaTuron Mar 30, 2023
e6fae80
Update src/commands/push.js
HonzaTuron Mar 30, 2023
e6ca6bc
feat(app): Add organization url redirect part
HonzaTuron Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/commands/push.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ const { flags: flagsHelper } = require('@oclif/command');
const actorTemplates = require('@apify/actor-templates');
const { ACT_JOB_STATUSES, ACT_SOURCE_TYPES,
MAX_MULTIFILE_BYTES } = require('@apify/consts');
const open = require('open');
const inquirer = require('inquirer');
const { ApifyCommand } = require('../lib/apify_command');
const { createActZip, getLoggedClientOrThrow,
outputJobLog, getLocalUserInfo, getActorLocalFilePaths,
Expand Down Expand Up @@ -32,6 +34,8 @@ class PushCommand extends ApifyCommand {
const apifyClient = await getLoggedClientOrThrow();
const localConfig = await getLocalConfigOrThrow();
const userInfo = await getLocalUserInfo();
const isOrganizationLoggedIn = !!userInfo.organizationOwnerUserId;
const redirectUrlPart = isOrganizationLoggedIn ? `/organization/${userInfo.id}` : '';

let actorId;
let actor;
Expand Down Expand Up @@ -152,7 +156,15 @@ class PushCommand extends ApifyCommand {

build = await apifyClient.build(build.id).get();

outputs.link('Actor build detail', `https://console.apify.com/actors/${build.actId}#/builds/${build.buildNumber}`);
outputs.link('Actor build detail', `https://console.apify.com${redirectUrlPart}/actors/${build.actId}#/builds/${build.buildNumber}`);

const shouldOpenBrowser = await inquirer.prompt([
{ type: 'confirm', name: 'continue', message: 'Do you want to open the actor detail in your browser?', default: true },
]);

if (shouldOpenBrowser.continue) {
open(`https://console.apify.com${redirectUrlPart}/actors/${build.actId}`);
}

if (build.status === ACT_JOB_STATUSES.SUCCEEDED) {
outputs.success('Actor was deployed to Apify cloud and built there.');
Expand Down