Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add schema parameter to getOrCreate for kvs, dataset #233

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

jirimoravcik
Copy link
Member

No description provided.

@mtrunkat
Copy link
Member

@jirimoravcik would be better to have signature .storageClient.getOrCreate(name, { schema }) so that we can later add more params into the params object

@jirimoravcik jirimoravcik marked this pull request as ready for review February 14, 2022 21:39
@jirimoravcik
Copy link
Member Author

@B4nan Should I bump the package version or something?

@B4nan
Copy link
Member

B4nan commented Feb 15, 2022

right, 2.2.0 is out, so we need a bump

technically minor one, personally i'd just do a patch as it seems like a small change, will leave it up to you :]

@jirimoravcik
Copy link
Member Author

right, 2.2.0 is out, so we need a bump

technically minor one, personally i'd just do a patch as it seems like a small change, will leave it up to you :]

Went for 2.2.1, added an entry to the changelog, is it ok like this?

@B4nan
Copy link
Member

B4nan commented Feb 16, 2022

sure, feel free to merge

@jirimoravcik jirimoravcik merged commit 032ecae into master Feb 16, 2022
@jirimoravcik jirimoravcik deleted the feature/get-or-create-with-schema branch February 16, 2022 12:33
@jirimoravcik jirimoravcik added enhancement New feature or request. medium priority Medium priority issues to be done in a couple of sprints. labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. medium priority Medium priority issues to be done in a couple of sprints.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants