Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Actor/Apify env vars instead of ENV_VARS #373

Merged
merged 3 commits into from Jul 20, 2023
Merged

feat: use Actor/Apify env vars instead of ENV_VARS #373

merged 3 commits into from Jul 20, 2023

Conversation

jirimoravcik
Copy link
Member

@jirimoravcik jirimoravcik commented Jul 12, 2023 •
edited

No description provided.

drobnikj
drobnikj reviewed Jul 14, 2023
View reviewed changes
src/apify_client.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the 67th sprint - Platform team milestone Jul 14, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jul 14, 2023
fnesveda
fnesveda approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a note that we need to deploy the worker changes before we release this

@jirimoravcik
Copy link
Member Author

Looks good, just a note that we need to deploy the worker changes before we release this

Yeah, you're right. I forgot to mention it in the PR, sorry.

@jirimoravcik jirimoravcik merged commit b2743f5 into master Jul 20, 2023
5 checks passed
@jirimoravcik jirimoravcik deleted the feature/use-actor-env-vars branch July 20, 2023 08:28
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

@drobnikj drobnikj drobnikj approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
68th sprint - Platform team
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jirimoravcik @fnesveda @drobnikj