-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(request-queue): Extend rq documentation with rqv2 features #904
Conversation
I got lots of warnings from Lychee. I don't care if you want to do changes directly into my code. Maybe it is better than commenting. @TC-MO |
I see 1 error in lychee 404, but from what I understand it is because you are already linking to the tutorial that you will create at later point? |
Yep, I would create a tutorial in a separate PR. |
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
I assume that this part of documentation won't be released until the new tutorial is released as well in a separate PR right? If not then I would suggest commenting out the link so we don't put a 404 in our docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some suggestions for improvement, plus I think in general you should link to the API client documentation more.
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just Franta's point + TODOs
…y#904) This is part of announcing request queue V2. The features described here were already implemented on backend but not promoted yet. I will create one more PR with adding new tutorial under [Advanced web scraping academy](https://docs.apify.com/academy/advanced-web-scraping) on How to scraper one request queue from multiple Actor runs. --------- Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com> Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
…y#904) This is part of announcing request queue V2. The features described here were already implemented on backend but not promoted yet. I will create one more PR with adding new tutorial under [Advanced web scraping academy](https://docs.apify.com/academy/advanced-web-scraping) on How to scraper one request queue from multiple Actor runs. --------- Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com> Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
…y#904) This is part of announcing request queue V2. The features described here were already implemented on backend but not promoted yet. I will create one more PR with adding new tutorial under [Advanced web scraping academy](https://docs.apify.com/academy/advanced-web-scraping) on How to scraper one request queue from multiple Actor runs. --------- Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com> Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
This is part of announcing request queue V2. The features described here were already implemented on backend but not promoted yet.
I will create one more PR with adding new tutorial under Advanced web scraping academy on How to scraper one request queue from multiple Actor runs.