Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request-queue): Extend rq documentation with rqv2 features #904

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

drobnikj
Copy link
Member

@drobnikj drobnikj commented Mar 27, 2024

This is part of announcing request queue V2. The features described here were already implemented on backend but not promoted yet.

I will create one more PR with adding new tutorial under Advanced web scraping academy on How to scraper one request queue from multiple Actor runs.

@drobnikj drobnikj requested a review from TC-MO as a code owner March 27, 2024 16:30
@drobnikj drobnikj marked this pull request as draft March 27, 2024 16:30
@github-actions github-actions bot added this to the 86th sprint - Platform team milestone Mar 27, 2024
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Mar 27, 2024
@drobnikj drobnikj removed the request for review from TC-MO March 28, 2024 09:56
@drobnikj drobnikj requested a review from mtrunkat March 28, 2024 12:54
@drobnikj
Copy link
Member Author

I got lots of warnings from Lychee. I don't care if you want to do changes directly into my code. Maybe it is better than commenting. @TC-MO

@TC-MO
Copy link
Contributor

TC-MO commented Mar 28, 2024

I see 1 error in lychee 404, but from what I understand it is because you are already linking to the tutorial that you will create at later point?

@drobnikj
Copy link
Member Author

drobnikj commented Apr 2, 2024

the tutorial that you will create at later point?

Yep, I would create a tutorial in a separate PR.

sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Show resolved Hide resolved
sources/platform/storage/request_queue.md Show resolved Hide resolved
@drobnikj drobnikj requested a review from mtrunkat April 3, 2024 13:16
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
@TC-MO
Copy link
Contributor

TC-MO commented Apr 4, 2024

I assume that this part of documentation won't be released until the new tutorial is released as well in a separate PR right?

If not then I would suggest commenting out the link so we don't put a 404 in our docs

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some suggestions for improvement, plus I think in general you should link to the API client documentation more.

sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
sources/platform/storage/request_queue.md Outdated Show resolved Hide resolved
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
Copy link
Member

@mtrunkat mtrunkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Franta's point + TODOs

@apify apify deleted a comment from fnesveda Apr 9, 2024
@drobnikj drobnikj requested a review from fnesveda April 9, 2024 11:10
@drobnikj drobnikj merged commit 9abdcb1 into master Apr 10, 2024
6 of 7 checks passed
@drobnikj drobnikj deleted the feat/rqv2 branch April 10, 2024 14:31
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Apr 15, 2024
honzajavorek pushed a commit to honzajavorek/apify-docs that referenced this pull request Apr 24, 2024
…y#904)

This is part of announcing request queue V2. The features described here
were already implemented on backend but not promoted yet.

I will create one more PR with adding new tutorial under [Advanced web
scraping academy](https://docs.apify.com/academy/advanced-web-scraping)
on How to scraper one request queue from multiple Actor runs.

---------

Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
honzajavorek pushed a commit to honzajavorek/apify-docs that referenced this pull request May 20, 2024
…y#904)

This is part of announcing request queue V2. The features described here
were already implemented on backend but not promoted yet.

I will create one more PR with adding new tutorial under [Advanced web
scraping academy](https://docs.apify.com/academy/advanced-web-scraping)
on How to scraper one request queue from multiple Actor runs.

---------

Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
honzajavorek pushed a commit to honzajavorek/apify-docs that referenced this pull request May 21, 2024
…y#904)

This is part of announcing request queue V2. The features described here
were already implemented on backend but not promoted yet.

I will create one more PR with adding new tutorial under [Advanced web
scraping academy](https://docs.apify.com/academy/advanced-web-scraping)
on How to scraper one request queue from multiple Actor runs.

---------

Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants