fix: only print status message when explicitly provided in `Actor.exi…

…t()` (#203)
apify · Jun 9, 2023 · 85159e4 · 85159e4
1 parent 08db28b
commit 85159e4
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 40 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -2,5 +2,4 @@
 # See: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
 
 # To keep eye on new functions added to Actor specification
-/packages/apify/src/            @jancurn
-/packages/apify/src/            @mnmkng
+/packages/apify/src/            @jancurn @mnmkng
diff --git a/packages/apify/src/actor.ts b/packages/apify/src/actor.ts
@@ -248,14 +248,10 @@ export class Actor<Data extends Dictionary = Dictionary> {
             finished = true;
         }
 
-        if (options.exitCode > 0) {
-            options.statusMessage ??= `Actor finished with an error (exit code ${options.exitCode})`;
-        } else {
-            options.statusMessage ??= `Actor finished successfully (exit code ${options.exitCode})`;
+        if (options.statusMessage != null) {
+            await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true, level: options.exitCode > 0 ? LogLevel.ERROR : LogLevel.INFO });
         }
 
-        await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true, level: options.exitCode > 0 ? LogLevel.ERROR : LogLevel.INFO });
-
         if (!options.exit) {
             return;
         }

diff --git a/website/package-lock.json b/website/package-lock.json
diff --git a/website/package.json b/website/package.json
@@ -15,30 +15,30 @@
     "devDependencies": {
         "@apify/eslint-config-ts": "^0.3.0",
         "@apify/tsconfig": "^0.1.0",
-        "@types/react": "^17.0.39",
-        "@typescript-eslint/eslint-plugin": "^5.13.0",
-        "@typescript-eslint/parser": "^5.13.0",
-        "eslint": "^8.10.0",
-        "eslint-plugin-react": "^7.29.3",
-        "eslint-plugin-react-hooks": "^4.3.0",
-        "fs-extra": "^11.0.0",
+        "@types/react": "^18.2.8",
+        "@typescript-eslint/eslint-plugin": "^5.59.9",
+        "@typescript-eslint/parser": "^5.59.9",
+        "eslint": "^8.42.0",
+        "eslint-plugin-react": "^7.32.2",
+        "eslint-plugin-react-hooks": "^4.6.0",
+        "fs-extra": "^11.1.1",
         "got": "^11.8.2",
         "path-browserify": "^1.0.1",
-        "prettier": "^2.5.1",
+        "prettier": "^2.8.8",
         "rimraf": "^5.0.0"
     },
     "dependencies": {
-        "@apify/docs-theme": "^1.0.78",
-        "@docusaurus/core": "^2.3.0",
-        "@docusaurus/plugin-client-redirects": "^2.3.0",
-        "@docusaurus/preset-classic": "^2.3.0",
+        "@apify/docs-theme": "^1.0.85",
+        "@docusaurus/core": "^2.4.1",
+        "@docusaurus/plugin-client-redirects": "^2.4.1",
+        "@docusaurus/preset-classic": "^2.4.1",
         "clsx": "^1.2.1",
         "docusaurus-gtm-plugin": "^0.0.2",
         "docusaurus-plugin-typedoc-api": "^3.0.0",
         "prop-types": "^15.8.1",
         "raw-loader": "^4.0.2",
         "react": "^17.0.2",
         "react-dom": "^17.0.2",
-        "unist-util-visit": "^4.1.1"
+        "unist-util-visit": "^4.1.2"
     }
 }