New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling and logging for Apify proxy configuration #262
Comments
I'd say we generally want users to use proxy even locally, so they have the same setup as after the deployment. Agreed we could just print a warning instead of failing locally (= when |
Yes, ideally, everybody should use a proxy to have consistent behavior when running locally and when on the platform. But this leads to every new user who starts developing locally getting 2 errors:
Instead, we should optimize for a quick win in the onboarding flow, and new users should be able to run every template (if possible) without signing in and having proxy access. So:
@B4nan could you please prioritize this? There is a large potential as, at the moment every new user gets and error and then another error. So we believe this may largely improve onboarding. |
…d is found We use the proxy configuration in all the templates, as we want users to run behind a proxy all the times. This PR changes the internal mechanism to gracefully ignore the proxy configuration locally when we don't see a valid token or proxy password. This way, new users can run their actors locally without being logged in. Closes #262
…d is found We use the proxy configuration in all the templates, as we want users to run behind a proxy all the times. This PR changes the internal mechanism to gracefully ignore the proxy configuration locally when we don't see a valid token or proxy password. This way, new users can run their actors locally without being logged in. Closes #262
…d is found We use the proxy configuration in all the templates, as we want users to run behind a proxy all the times. This PR changes the internal mechanism to gracefully ignore the proxy configuration locally when we don't see a valid token or proxy password. This way, new users can run their actors locally without being logged in. Closes #262
…d is found (#272) We use the proxy configuration in all the templates, as we want users to run behind a proxy all the times. This PR changes the internal mechanism to gracefully ignore the proxy configuration locally when we don't see a valid token or proxy password. This way, new users can run their actors locally without being logged in. Closes #262
Released as v3.1.15, tried to use a fresh playwright template and it seems to be working fine. |
Feature
We want to change the behavior of the instance of
Actor.createProxyConfiguration
Current behavior:
Suggested change:
We would like to just print a warning to the console instead (or create some safer
createProxyConfiguration
) on the local environment. The Apify proxy just wouldn't be used at all, the configuration would do nothing.Also, we proposed adding an additional warning - if the user has access to the Apify proxy but can't use it locally (this must be explained properly - free plan users).
We also propose an improved copy for the original error.
apify login
cmd to get the proxy password.Motivation
Make Apify templates as seamless as possible. Now, a developer has to think about where it can be run and catch different errors. It is not clear from the error what to do and we have feedback from real users that struggled with this for quite some time.
Ideal solution or implementation, and any additional constraints
Make
Actor.createProxyConfiguration
with warnings instead of error for local environment.Alternative solutions or implementations
No response
Other context
No response
The text was updated successfully, but these errors were encountered: