Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log status message only once and without prefix #179

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: log status message only once and without prefix #179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b93543
fix: remove the status message prefix from the actual msg
barjin Mar 23, 2023
3909d7d
fix: remove double logging on Actor.exit
barjin Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/apify/src/actor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,11 @@ export class Actor<Data extends Dictionary = Dictionary> {

if (options.exitCode > 0) {
options.statusMessage ??= `Actor finished with an error (exit code ${options.exitCode})`;
log.error(options.statusMessage);
} else {
options.statusMessage ??= `Actor finished successfully (exit code ${options.exitCode})`;
log.info(options.statusMessage);
}

await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true });
await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true, level: options.exitCode > 0 ? LogLevel.ERROR : LogLevel.INFO });

if (!options.exit) {
return;
Expand Down Expand Up @@ -519,20 +517,20 @@ export class Actor<Data extends Dictionary = Dictionary> {
ow(statusMessage, ow.string);
ow(isStatusMessageTerminal, ow.optional.boolean);

statusMessage = `[Status message]: ${statusMessage}`;
const loggedStatusMessage = `[Status message]: ${statusMessage}`;

switch (level) {
case LogLevel.DEBUG:
log.debug(statusMessage);
log.debug(loggedStatusMessage);
break;
case LogLevel.WARNING:
log.warning(statusMessage);
log.warning(loggedStatusMessage);
break;
case LogLevel.ERROR:
log.error(statusMessage);
log.error(loggedStatusMessage);
break;
default:
log.info(statusMessage);
log.info(loggedStatusMessage);
break;
}

Expand Down