chore(deps): bump puppeteer support to 17.0 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
changed the title
vladfrangu
changed the title
vladfrangu
force-pushed
the
deps/puppeteer-15.1
branch
from
eece602
to
4e12b3b
Compare
vladfrangu
force-pushed
the
deps/puppeteer-15.1
branch
from
4e12b3b
to
9c7f5f7
Compare
vladfrangu
changed the title
|
we should merge this before shipping new version. i dont think the CI will get fixed itself somehow :] |
|
CI won't fix unless we release crawlee first @B4nan so yeah, maybe we should just merge it now |
|
Oh I see, I dont want to breake the build. We can use I would still like to explore conditional builds so we can depend on beta crawlee for dev versions and have the stable there for stable releases only. I feel like we will be falling into this regularly. |
|
Hmm, the CI is currently failing because the lock file is out of sync, let me fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs apify/crawlee#1469 firstNeeds apify/crawlee#1519