feat: added hiding of webdriver #70
Conversation
src/fingerprinting/hooks.ts
Outdated
| @@ -29,14 +30,17 @@ export function createFingerprintPreLaunchHook(browserPool: BrowserPool<any, any | |||
| } | |||
|
|
|||
| launchContext.extend({ fingerprint }); | |||
| // hide webdriver with arg. | |||
| // IMHO we could do this by default not only with fingerprinting. | |||
There was a problem hiding this comment.
thoughts @mnmkng @metalwarrior665?
There was a problem hiding this comment.
Yeah, agreed. I don't think it ever makes sense to run with webdriver: true
There was a problem hiding this comment.
we just have to be careful about using the proper method for different browsers
There was a problem hiding this comment.
I think we have this covered right now. Maybe we could move it to the plugins level. Playwright works only with build-in firefox and WebKit, which has hidden webDriver by default and hides it in chrome/chromium. We also hide it with Puppeteer chromium/chrome. Maybe we could hide it with the Puppeteer firefox. However, then we would have to hide it for safari and more browsers in Playwright, which is more complicated across versions.
There was a problem hiding this comment.
Playwright ... hides it in chrome/chromium.
Does it really though? It might hide it for Chromium, but it definitely did not hide it for Chrome the last time I tested it.
There was a problem hiding this comment.
It does not because it is not the default browser. My point is that in other default browsers, the webdriver is false. In chromium-based browsers, we can control it by the argument. However, in other browsers, we have to set the webdriver to false, which needs the fingerprint injector toolkit (webdriver is one of the overridden properties). So my point is that my initial proposal was wrong, and hiding webdriver generally is a fingerprint change that requires the stealth override functions 😄
There was a problem hiding this comment.
I would release it like this. We want to turn on the fingerprints by default anyway, right?
There was a problem hiding this comment.
I would like webdriver to be false with the default SDK configuration. Without any extra steps needed for the user. Otherwise, I don't care that much how it works 😄
Co-authored-by: Martin Adámek <banan23@gmail.com>
|
Where are we with this? Can we merge, or is there something missing? |
|
This is done IMHO. We can merge. |
|
cc @AndreyBykov, please backport this commit too |
Maybe we could add this as the default launch args, but I feel this kind of changes the browser fingerprint to stick with this.