fix(puppeteer): replace page.waitForTimeout() with sleep()

Closes #2335
apify · Feb 15, 2024 · 52d7219 · 52d7219
1 parent a8cd603
commit 52d7219
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/puppeteer-crawler/src/internals/utils/puppeteer_utils.ts b/packages/puppeteer-crawler/src/internals/utils/puppeteer_utils.ts
@@ -26,7 +26,7 @@ import log_ from '@apify/log';
 import type { Request } from '@crawlee/browser';
 import { KeyValueStore, RequestState, validators, Configuration } from '@crawlee/browser';
 import type { Dictionary, BatchAddRequestsResult } from '@crawlee/types';
-import type { CheerioRoot } from '@crawlee/utils';
+import { type CheerioRoot, sleep } from '@crawlee/utils';
 import * as cheerio from 'cheerio';
 import type { ProtocolMapping } from 'devtools-protocol/types/protocol-mapping.js';
 import { getInjectableScript } from 'idcac-playwright';
@@ -524,7 +524,7 @@ export async function infiniteScroll(page: Page, options: InfiniteScrollOptions
     let retry = 0;
 
     while (!body && retry < 10) {
-        await page.waitForTimeout(100);
+        await sleep(100);
         body = await page.$('body');
         retry++;
     }
@@ -584,7 +584,7 @@ export async function infiniteScroll(page: Page, options: InfiniteScrollOptions
 
     while (!finished) {
         await doScroll();
-        await page.waitForTimeout(250);
+        await sleep(250);
         if (scrollDownAndUp) {
             await page.mouse.wheel({ deltaY: -1000 });
         }

diff --git a/test/e2e/puppeteer-default/actor/main.js b/test/e2e/puppeteer-default/actor/main.js
@@ -11,7 +11,8 @@ await Actor.main(async () => {
         preNavigationHooks: [(_ctx, goToOptions) => {
             goToOptions.waitUntil = ['networkidle2'];
         }],
-        async requestHandler({ page, enqueueLinks, request }) {
+        async requestHandler({ page, enqueueLinks, request, infiniteScroll }) {
+            await infiniteScroll();
             const { url } = request;
             const pageTitle = await page.title();
             await Dataset.pushData({ url, pageTitle });