fix: make router error message more helpful for undefined routes (#1678)

apify · Nov 14, 2022 · ab359d8 · ab359d8
1 parent 20d574b
commit ab359d8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/packages/core/src/router.ts b/packages/core/src/router.ts
@@ -115,12 +115,11 @@ export class Router<Context extends CrawlingContext> {
             return this.routes.get(defaultRoute)!;
         }
 
-        if (!label) {
-            // eslint-disable-next-line max-len
-            throw new MissingRouteError(`No default route set up. Please specify 'requestHandler' option or provide default route via 'crawler.router.addDefaultRoute()'.`);
-        }
-
-        throw new MissingRouteError(`Route not found for label '${String(label)}' and no default route set up!`);
+        throw new MissingRouteError(
+            `Route not found for label '${String(label)}'.`
+            + ' You must set up a route for this label or a default route.'
+            + ' Use `requestHandler`, `router.addHandler` or `router.addDefaultHandler`.',
+        );
     }
 
     /**

diff --git a/test/core/crawlers/cheerio_crawler.test.ts b/test/core/crawlers/cheerio_crawler.test.ts
@@ -190,7 +190,7 @@ describe('CheerioCrawler', () => {
         });
 
         // eslint-disable-next-line max-len
-        await expect(cheerioCrawler.run()).rejects.toThrow(`No default route set up. Please specify 'requestHandler' option or provide default route via 'crawler.router.addDefaultRoute()'.`);
+        await expect(cheerioCrawler.run()).rejects.toThrow("Route not found for label 'undefined'. You must set up a route for this label or a default route. Use `requestHandler`, `router.addHandler` or `router.addDefaultHandler`.");
     });
 
     test('should ignore ssl by default', async () => {