fix: session pool leaks memory on multiple crawler runs (#2083)

Fixes #2074 Related #2031 --------- Co-authored-by: Martin Adámek <banan23@gmail.com>
apify · Sep 20, 2023 · b96582a · b96582a
1 parent 75302e0
commit b96582a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/packages/basic-crawler/src/internals/basic-crawler.ts b/packages/basic-crawler/src/internals/basic-crawler.ts
@@ -775,6 +775,7 @@ export class BasicCrawler<Context extends CrawlingContext = BasicCrawlingContext
         this.running = true;
         this.stats.reset();
         await this.stats.resetStore();
+        await this.sessionPool?.resetStore();
 
         await purgeDefaultStorages({ onlyPurgeOnce: true });
 

diff --git a/packages/core/src/session_pool/session_pool.ts b/packages/core/src/session_pool/session_pool.ts
@@ -290,6 +290,10 @@ export class SessionPool extends EventEmitter {
         return this._createSession();
     }
 
+    async resetStore() {
+        await this.keyValueStore?.setValue(this.persistStateKey, null);
+    }
+
     /**
      * Returns an object representing the internal state of the `SessionPool` instance.
      * Note that the object's fields can change in future releases.