fix: handle non-error objects thrown gracefully (#1652)

apify · Nov 2, 2022 · c3a4e1a · c3a4e1a
1 parent f7ad886
commit c3a4e1a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/packages/utils/src/internals/error_tracker.ts b/packages/utils/src/internals/error_tracker.ts
@@ -219,6 +219,10 @@ const mergeMessages = (a: string, b: string, storage: Record<string, unknown>) =
 const getErrorMessageGroup = (error: ErrnoException, storage: Record<string, unknown>, showFullMessage: boolean) => {
     let { message } = error;
 
+    if (!message) {
+        message = typeof error === 'string' ? error : `Unknown error message. Received non-error object: ${JSON.stringify(error)}`;
+    }
+
     if (!showFullMessage) {
         const newLineIndex = message.indexOf('\n');
         message = message.slice(0, newLineIndex === -1 ? undefined : newLineIndex);

diff --git a/packages/utils/test/non-error-objects-working.test.ts b/packages/utils/test/non-error-objects-working.test.ts
@@ -0,0 +1,9 @@
+import { ErrorTracker } from '../src/internals/error_tracker';
+
+describe('ErrorTracker', () => {
+    test('processing a non-error error should not crash', () => {
+        const errorTracker = new ErrorTracker();
+        // @ts-expect-error tracking non-error errors
+        expect(() => errorTracker.add('foo')).not.toThrow();
+    });
+});