Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump puppeteer support to 17.x #1519

Merged
merged 5 commits into from Sep 5, 2022
Merged

Conversation

vladfrangu
Copy link
Member

No description provided.

await sendCDPCommand(page, 'Network.setBlockedURLs', { urls: patternsToBlock });
}

export async function sendCDPCommand<T extends keyof ProtocolMapping.Commands>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we reexport everything from this file, if so, we should add @internal jsdoc here

@B4nan B4nan changed the title chore(deps): bump puppeteer support to 17.x feat: bump puppeteer support to 17.x Sep 5, 2022
@B4nan B4nan merged commit b97a852 into master Sep 5, 2022
@B4nan B4nan deleted the deps/bump-puppeteer-to-17.1 branch September 5, 2022 10:31
@B4nan
Copy link
Member

B4nan commented Sep 5, 2022

will tag this as a feature so we have it in the generated changelogs, i think its worth mentioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants