-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dataset.exportToValue
#1553
Conversation
saveToValue
methodexportToValue
method
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
exportToValue
methodDataset.exportToValue
await kvStore.setValue(key || 'OUTPUT', await this.client.listItems(), recordOptions); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mstephen19 @B4nan what's the contentType
option for when there's no way to actually output a different thing than a JSON? It's not gonna magically turn to CSV just by setting the content type to it 😅 It's just gonna create a corrupted file
Also listItems()
might be absolutely huge. This needs to be done in a streaming fashion.
Finally, the exported JSON (or CSV) should include just items
and not the whole object with pagination information.
closes #1523
Allows the entirety of the dataset's contents to be saved to a key-value store under a custom key, and with a custom
contentType
.