feat: add Dataset.exportToValue
#1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
changed the title
saveToValue methodexportToValue method
B4nan
reviewed
Sep 21, 2022
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
B4nan
approved these changes
Sep 22, 2022
B4nan
approved these changes
Sep 23, 2022
B4nan
changed the title
exportToValue methodDataset.exportToValue
mnmkng
reviewed
Sep 23, 2022
Comment on lines
+300
to
+301
| await kvStore.setValue(key || 'OUTPUT', await this.client.listItems(), recordOptions); | ||
| } |
There was a problem hiding this comment.
@mstephen19 @B4nan what's the contentType option for when there's no way to actually output a different thing than a JSON? It's not gonna magically turn to CSV just by setting the content type to it 😅 It's just gonna create a corrupted file
Also listItems() might be absolutely huge. This needs to be done in a streaming fashion.
Finally, the exported JSON (or CSV) should include just items and not the whole object with pagination information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1523
Allows the entirety of the dataset's contents to be saved to a key-value store under a custom key, and with a custom
contentType.