fix: type errors when playwright is not installed

[szmarczak]

Fixes #1610
Closes #1629

[szmarczak]

Do we also need

crawlee/scripts/typescript_fixes.mjs

Lines 18 to 28 in 7a2217d

	} else if (
	// playwright/puppeteer import
	line.match(/^([^']+)'(playwright|puppeteer)'/) ||
	// proxy-per-page reexport of puppeteer
	line.match(/: Puppeteer\.\w+/) ||
	// don't ask me why, but this one is needed too ¯\_(ツ)_/¯
	line.match(/^export interface (PlaywrightHook|PuppeteerHook)/)
	) {
	output.push('// @ts-ignore optional peer dependency');
	output.push(line);
	changed = true;

?

Doesn't import type return any when a type does not exist? So // @ts-ignore shouldn't be necessary.

[vladfrangu]

Does this supersede #1629? 👀

[vladfrangu]

Doesn't import type return any when a type does not exist?

Nope, it'll still throw an error like importing without the type modifier 😓

[szmarczak]

Nope, it'll still throw an error like importing without the type modifier sweat

Shouldn't we use await import in that case? OTOH it may not work in cases where synchronous work is done first and that exposed via a synchronous function as well. That could be launching a browser for example (I think it's async though). However in ESM optional deps should be loaded via await import.

Edit: yep importing non-installed package throws. That's gonna be a separate task I guess.

[vladfrangu]

Tested this locally and it works 🎉

[B4nan]

we should move this to @crawlee/types (probably), and mark it as @internal (definitely)