Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawlee adds --no-sandbox where it shouldn't #1797

Closed
1 task
mnmkng opened this issue Feb 21, 2023 · 1 comment · Fixed by #2148
Closed
1 task

Crawlee adds --no-sandbox where it shouldn't #1797

mnmkng opened this issue Feb 21, 2023 · 1 comment · Fixed by #2148
Assignees
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@mnmkng
Copy link
Member

mnmkng commented Feb 21, 2023

Which package is this bug report for? If unsure which one to select, leave blank

None

Issue description

I could use the playwright + webkit locally, but on the platform it only shows error:

2023-02-21T13:35:49.515Z WARN PlaywrightCrawler: Reclaiming failed request back to the list or queue. browserType.launchPersistentContext: Browser closed.
2023-02-21T13:35:49.517Z ==================== Browser output: ====================
2023-02-21T13:35:49.519Z /home/myuser/pw-browsers/MiniBrowser --inspector-pipe --user-data-dir=/tmp/playwright_webkitdev_profile-jStjK1 --proxy=http://127.0.0.1:43893/ --no-sandbox about:blank
2023-02-21T13:35:49.521Z pid=42
2023-02-21T13:35:49.523Z [pid=42][err] Cannot parse arguments: Unknown option --no-sandbox
2023-02-21T13:35:49.524Z =========================== logs ===========================
2023-02-21T13:35:49.526Z /home/myuser/pw-browsers/MiniBrowser --inspector-pipe --user-data-dir=/tmp/playwright_webkitdev_profile-jStjK1 --proxy=http://127.0.0.1:43893/ --no-sandbox about:blank
2023-02-21T13:35:49.528Z pid=42
2023-02-21T13:35:49.530Z [pid=42][err] Cannot parse arguments: Unknown option --no-sandbox
2023-02-21T13:35:49.532Z ============================================================
2023-02-21T13:35:49.534Z /home/myuser/pw-browsers/MiniBrowser --inspector-pipe --user-data-dir=/tmp/playwright_webkitdev_profile-jStjK1 --proxy=http://127.0.0.1:43893/ --no-sandbox about:blank

Code sample

No response

Package version

x

Node.js version

x

Operating system

No response

Apify platform

  • Tick me if you encountered this issue on the Apify platform

I have tested this on the next release

No response

Other context

Crawlee automatically adds --no-sandbox when isAtHome() === true

Apparently it needs to be a little smarter now with other browsers in place.

@mnmkng mnmkng added the bug Something isn't working. label Feb 21, 2023
@AndreyBykov
Copy link
Member

Will just leave it there that if webkit is needed urgently - this could be solved by providing the respective env variable process.env.CRAWLEE_DISABLE_BROWSER_SANDBOX = false;, or by disabling the respective configuration option.

@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants