fix(MemoryStorage): cache requests in RequestQueue
#1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnmkng
reviewed
May 5, 2023
I think what I just pushed should be enough, but let me know if it isn't |
mnmkng
approved these changes
May 5, 2023
B4nan
changed the title
B4nan
changed the title
RequestQueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is added because request queues tend to have a lot of activity on one entry, until the request is finished. This should ensure that no more invalid JSON errors are thrown, while also keeping the memory footprint low once a request entry is no longer accessed (+re-loading from fs if that happens)