feat: add LinkeDOMCrawler #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strajk
force-pushed
the
feat/linkedomcrawler
branch
from
2cac242
to
821d3ed
Compare
|
🏓 |
B4nan
reviewed
May 29, 2023
There was a problem hiding this comment.
we need some tests too :] maybe just duplicate this e2e test for jsdom?
https://github.com/apify/crawlee/tree/master/test/e2e/jsdom-default-ts
| @@ -7,6 +7,7 @@ | |||
| "@crawlee/basic": ["packages/basic-crawler/src"], | |||
| "@crawlee/browser": ["packages/browser-crawler/src"], | |||
| "@crawlee/http": ["packages/http-crawler/src"], | |||
| "@crawlee/linkedom": ["packages/linkedom-crawler/src"], | |||
There was a problem hiding this comment.
this also needs to be done in the root tsconfig.json (iirc that is what the IDE/ts language server is using when you want to click to definition, etc)
| @@ -0,0 +1,64 @@ | |||
| { | |||
| "name": "@crawlee/linkedom", | |||
| "version": "3.3.1", | |||
There was a problem hiding this comment.
Suggested change
| "version": "3.3.1", | |
| "version": "3.3.2", |
and this will require regenerating the lockfile, plus a rebase is needed anyway i guess
Strajk
force-pushed
the
feat/linkedomcrawler
branch
from
53f0a1c
to
1c35463
Compare
|
B4nan
reviewed
Jun 7, 2023
|
sorry for the waiting, and thanks again :] |
|
thxxx! no worries mr. banan :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clean approach of #1879
as discussed #1890 (comment)
2023-05-09 16:05 Rebased