-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LinkeDOMCrawler #1907
Conversation
2cac242
to
821d3ed
Compare
🏓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need some tests too :] maybe just duplicate this e2e test for jsdom?
https://github.com/apify/crawlee/tree/master/test/e2e/jsdom-default-ts
@@ -7,6 +7,7 @@ | |||
"@crawlee/basic": ["packages/basic-crawler/src"], | |||
"@crawlee/browser": ["packages/browser-crawler/src"], | |||
"@crawlee/http": ["packages/http-crawler/src"], | |||
"@crawlee/linkedom": ["packages/linkedom-crawler/src"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also needs to be done in the root tsconfig.json
(iirc that is what the IDE/ts language server is using when you want to click to definition, etc)
@@ -0,0 +1,64 @@ | |||
{ | |||
"name": "@crawlee/linkedom", | |||
"version": "3.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "3.3.1", | |
"version": "3.3.2", |
and this will require regenerating the lockfile, plus a rebase is needed anyway i guess
53f0a1c
to
1c35463
Compare
sorry for the waiting, and thanks again :] |
The clean approach of #1879
as discussed #1890 (comment)
2023-05-09 16:05 Rebased