duplicate file extension when saveSnapshot

[clyer]

Which package is this bug report for? If unsure which one to select, leave blank

@crawlee/playwright (PlaywrightCrawler)

Issue description

1. run saveSnapshot(page)
2. expect SNAPSHOT.jpg saved, but got SNAPSHOT.jpg.jpeg. Also same issue with html file.

Key under which the screenshot and HTML will be saved. .jpg will be appended for screenshot and .html for HTML.

3. The file name with extension has already been concatenated in playwright-utils, but in key-value-store, the extension is parsed based on "contentType" and concatenated again.

@crawlee/puppeteer has same issue.

Code sample

No response

Package version

3.4.0

Node.js version

16.15.1

Operating system

No response

Apify platform

• Tick me if you encountered this issue on the Apify platform

I have tested this on the next release

No response

Other context

No response

[damianr13]

I encountered the same issue.

Here is what I found out about it:

The KeyValueStoreClient assigns an extension to the file based on the content type:

crawlee/packages/memory-storage/src/resource-clients/key-value-store.ts

Line 274 in 4aabd16

const extension = mime.extension(contentType) || DEFAULT_LOCAL_FILE_EXTENSION;

(that is our .jpeg extension)

The function saveSnapshot also assign an extension to the file:

crawlee/packages/playwright-crawler/src/internals/utils/playwright-utils.ts

Line 539 in ff5cfbf

const screenshotName = `${key}.jpg`;

(that is our .jpg extension)

My opinion is that KeyValueStoreClient should detect that the file name already has an extension that matches the content type and not add one anymore.