feat: add support for sameDomainDelay
#2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dineshhardasani
changed the title
|
@B4nan As of now, I have attempted to add functionality for introducing a delay in same domain requests. Could you please review these changes? |
B4nan
requested changes
Jul 21, 2023
|
also do the rebase so we can run the tests, i have a hunch this will break them. which brings me to the next step - we need tests for this as well |
|
Added fix for above comments and rebased branch. @B4nan |
|
thanks for the changes, this looks much better! will take a closer look later today or tomorrow |
B4nan
changed the title
sameDomainDelay
B4nan
requested changes
Jul 27, 2023
B4nan
reviewed
Jul 27, 2023
B4nan
reviewed
Jul 27, 2023
barjin
reviewed
Jul 28, 2023
barjin
reviewed
Jul 28, 2023
Co-authored-by: Jindřich Bär <jindrichbar@gmail.com>
|
I will merge this as I want to release a new minor version this morning, but we still want to see some tests for this new feature, so please PR that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new feature to introduce a delay while crawling same domain requests.
closes #1993