-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for sameDomainDelay
#2003
Conversation
@B4nan As of now, I have attempted to add functionality for introducing a delay in same domain requests. Could you please review these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, left a few initial comments before a deeper review - please focus on removing the unrelated changes and fixing the linter issues, so the produced diff makes more sense.
also do the rebase so we can run the tests, i have a hunch this will break them. which brings me to the next step - we need tests for this as well |
Added fix for above comments and rebased branch. @B4nan |
thanks for the changes, this looks much better! will take a closer look later today or tomorrow |
sameDomainDelay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking pretty good, last thing is to add a test case
Co-authored-by: Jindřich Bär <jindrichbar@gmail.com>
I will merge this as I want to release a new minor version this morning, but we still want to see some tests for this new feature, so please PR that separately. |
Implemented a new feature to introduce a delay while crawling same domain requests.
closes #1993