Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: session pool leaks memory on multiple crawler runs #2083

Merged
merged 2 commits into from Sep 20, 2023
Merged

fix: session pool leaks memory on multiple crawler runs #2083

merged 2 commits into from Sep 20, 2023

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Sep 18, 2023

Fixes #2074

Related #2031

@github-actions github-actions bot added this to the 72nd sprint - Tooling team milestone Sep 18, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 18, 2023
@barjin barjin requested a review from B4nan September 19, 2023 09:34
B4nan
B4nan approved these changes Sep 19, 2023
View reviewed changes
packages/core/src/session_pool/session_pool.ts Outdated Show resolved Hide resolved
@barjin @B4nan
fix: improve code readability
50e2854 
Co-authored-by: Martin Adámek <banan23@gmail.com>
@barjin barjin merged commit b96582a into master Sep 20, 2023
7 checks passed
@barjin barjin deleted the fix/sessionpool-memleak branch September 20, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees

@barjin barjin

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
72nd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

SDK_SESSION_POOL_STATE growing infinitely on crawler reruns
2 participants
@barjin @B4nan