fix: add skipNavigation option to enqueueLinks
#2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
requested changes
Oct 31, 2023
There was a problem hiding this comment.
thanks!
we need the same for puppeteer: https://github.com/apify/crawlee/blob/master/packages/puppeteer-crawler/src/internals/enqueue-links/click-elements.ts#L214
|
also the |
B4nan
approved these changes
Oct 31, 2023
|
I am trying to add some tests to it |
B4nan
changed the title
skipNavigation property to enqueueLinksByClickingElements
B4nan
reviewed
Oct 31, 2023
B4nan
reviewed
Oct 31, 2023
packages/playwright-crawler/src/internals/enqueue-links/click-elements.ts
Outdated
Show resolved
Hide resolved
gustavotr
force-pushed
the
chore/add-skipNavigation-to-enqueue-links
branch
from
98aeff0
to
92cd2b4
Compare
B4nan
reviewed
Nov 2, 2023
packages/playwright-crawler/src/internals/enqueue-links/click-elements.ts
Outdated
Show resolved
Hide resolved
packages/puppeteer-crawler/src/internals/enqueue-links/click-elements.ts
Outdated
Show resolved
Hide resolved
B4nan
changed the title
skipNavigation property to enqueueLinksByClickingElementsskipNavigation option to enqueueLinks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.