Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add skipNavigation option to enqueueLinks #2153

Merged
merged 6 commits into from Nov 2, 2023
Merged

fix: add skipNavigation option to enqueueLinks #2153

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49e0e49
chore: 🤖 add skipNavigation property to enqueueLinks
gustavotr Oct 31, 2023
14fc998
chore: 🤖 add skipNavigation to puppeteer
gustavotr Oct 31, 2023
095dc8d
chore: 🤖 add the skipNavigation to the actual request
gustavotr Oct 31, 2023
e09cef5
chore: add tests
gustavotr Oct 31, 2023
92cd2b4
refactor: 💡 format code
gustavotr Oct 31, 2023
acf04e5
Apply suggestions from code review
B4nan Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/playwright-crawler/src/internals/enqueue-links/click-elements.ts
View file
Open in desktop
Expand Up @@ -166,6 +166,12 @@ export interface EnqueueLinksByClickingElementsOptions {
* @default false
*/
forefront?: boolean;

/**
* If set to `true`, tells the crawler to skip navigation and process the request directly:
B4nan marked this conversation as resolved.
Show resolved Hide resolved
* @default false
*/
skipNavigation?: boolean;
}

/**
Expand Down Expand Up @@ -233,6 +239,7 @@ export async function enqueueLinksByClickingElements(options: EnqueueLinksByClic
maxWaitForPageIdleSecs: ow.optional.number,
label: ow.optional.string,
forefront: ow.optional.boolean,
skipNavigation: ow.optional.boolean,
}));

const {
Expand Down
7 changes: 7 additions & 0 deletions packages/puppeteer-crawler/src/internals/enqueue-links/click-elements.ts
View file
Open in desktop
Expand Up @@ -167,6 +167,12 @@ export interface EnqueueLinksByClickingElementsOptions {
* @default false
*/
forefront?: boolean;

/**
* If set to `true`, tells the crawler to skip navigation and process the request directly:
B4nan marked this conversation as resolved.
Show resolved Hide resolved
* @default false
*/
skipNavigation?: boolean;
}

/**
Expand Down Expand Up @@ -234,6 +240,7 @@ export async function enqueueLinksByClickingElements(options: EnqueueLinksByClic
maxWaitForPageIdleSecs: ow.optional.number,
label: ow.optional.string,
forefront: ow.optional.boolean,
skipNavigation: ow.optional.boolean,
}));

const {
Expand Down