Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: utils.apifyClient early instantiation #1330

Merged
merged 2 commits into from
Apr 13, 2022
Merged

fix: utils.apifyClient early instantiation #1330

merged 2 commits into from
Apr 13, 2022

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Apr 13, 2022

closes #1328

@barjin barjin marked this pull request as draft April 13, 2022 13:49
@barjin barjin marked this pull request as ready for review April 13, 2022 14:04
B4nan
B4nan approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a comment explaining why we need to use a proxy. test case would be nice too, but given there is no such global in v3 anymore, i guess we can live without that :]

and also please add it to the changelog

@B4nan B4nan merged commit 077c31d into apify:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apify performs actions when imported
2 participants
@barjin @B4nan