fix: random puppeteer crawler (running in headful mode) failure #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the random failure of actor runs using puppeteer crawler in headful mode. It first appeared in SDK 2.3.0 after updating puppeteer to version 13.
Seems like the issue appeared in puppeteer a long time ago, and is still not fixed. The last puppeteer version working without this issue is 10.4.0. My bet is it's related to OOP iframes changes in v11. The issue is pretty random though and hard to reproduce. Sometimes it happens after 1-2 requests are processed, sometimes after 10-15 minutes run, sometimes run could finish successfully. Adding
--disable-site-isolation-trialsflag fixes it.No need to add this flag to headless though. Also - the playwright seems to be working fine, so it's puppeteer-related only.