fix: rename default storage folder to just storage
#1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
force-pushed
the
rename-default-storage-folder
branch
3 times, most recently
from
543d9e0
to
66f6388
Compare
B4nan
force-pushed
the
rename-default-storage-folder
branch
2 times, most recently
from
de9f726
to
0a31015
Compare
Given we use the memory storage also in the Actor SDK, we don't want to have a crawlee specific name for the default storage folder, as it feels confusing to have `crawlee_storage` folder when you don't interact with `crawlee` anyhow. This change should not be breaking, if a folder called `crawlee_storage` exists, we still use it. If not, we use just `storage`.
B4nan
force-pushed
the
rename-default-storage-folder
branch
from
0a31015
to
658b431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we use the memory storage also in the Actor SDK, we don't want to have a crawlee specific name for the default storage folder, as it feels confusing to have
crawlee_storagefolder when you don't interact withcrawleeanyhow.This change should not be breaking, if a folder called
crawlee_storageexists, we still use it. If not, we use juststorage.