Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add parseWithCheerio for puppeteer & playwright #1418

Merged
merged 4 commits into from
Jul 23, 2022
Merged

feat: add parseWithCheerio for puppeteer & playwright #1418

merged 4 commits into from
Jul 23, 2022

Conversation

AndreyBykov
Copy link
Member

add the respective options for both utils and for context utils.
add the tests.
also fixed pptr links in utils

@AndreyBykov AndreyBykov requested a review from B4nan July 23, 2022 17:31
B4nan
B4nan approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but double check the dependencies are declared, eg pw carwler package probably does not have cheerio there.

@AndreyBykov
Copy link
Member Author

Yeah, you're right. Added. crawlee utils is already there. Now should be good.

@B4nan B4nan merged commit 02b0aeb into master Jul 23, 2022
@B4nan B4nan deleted the feat/parseWithCheerio branch July 23, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndreyBykov @B4nan