fix: regression in resolving the base url for enqueue link filtering #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
deleted the
fix/regression-in-resolve-base-url-for-enqueue-link-filtering
branch
mnmkng
reviewed
Jul 26, 2022
Comment on lines
+300
to
+309
| if (enqueueStrategy === EnqueueStrategy.SameDomain) { | ||
| const originalHostname = getDomain(originalUrlOrigin, { mixedInputs: false })!; | ||
| const finalHostname = getDomain(finalUrlOrigin, { mixedInputs: false })!; | ||
|
|
||
| if (originalHostname === finalHostname) { | ||
| return finalUrlOrigin; | ||
| } | ||
|
|
||
| return undefined; | ||
| } |
There was a problem hiding this comment.
Not sure if this is a problem or not, so just leaving it here for consideration. In the Crawlee tutorials which i'm now rewriting, I saw an origin comparison used instead of hostname. The thing is, origin includes the protocol and the hostname does not. This means that URLs with the same hostname, but different protocol (eg http vs https), would be filtered out.
Please check or confirm that it behaves correctly in Crawlee and it was just wrong in the example code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.