Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sendRequest types #1445

Merged
merged 5 commits into from
Aug 8, 2022
Merged

fix: sendRequest types #1445

merged 5 commits into from
Aug 8, 2022

Conversation

szmarczak
Copy link
Contributor

@szmarczak szmarczak commented Aug 5, 2022 •
edited
Loading

Fixes #1444

B4nan
B4nan reviewed Aug 7, 2022
View reviewed changes
test/core/crawlers/basic_crawler.test.ts Outdated Show resolved Hide resolved
test/core/crawlers/basic_crawler.test.ts Outdated Show resolved Hide resolved
packages/basic-crawler/src/internals/basic-crawler.ts Outdated Show resolved Hide resolved
packages/basic-crawler/src/internals/basic-crawler.ts Show resolved Hide resolved
@szmarczak szmarczak requested a review from B4nan August 8, 2022 09:07
@szmarczak szmarczak merged commit 751563b into master Aug 8, 2022
@szmarczak szmarczak deleted the fix-sr branch August 8, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBykov AndreyBykov Awaiting requested review from AndreyBykov

@B4nan B4nan Awaiting requested review from B4nan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sendRequest fails if BasicCrawler has sessionPool disabled
2 participants
@szmarczak @B4nan