feat: retryOnBlocked detects blocked webpage #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barjin
force-pushed
the
feat/retryOnBlocked
branch
from
f571217
to
197cd18
Compare
B4nan
requested changes
Jul 3, 2023
| if (this.retryOnBlocked) { | ||
| if (await this.isGettingBlocked(crawlingContext)) { | ||
| session?.retire(); | ||
| throw new Error('Antibot protection detected, the session has been retired.'); |
There was a problem hiding this comment.
maybe we should throw RetryRequestError? but that could end up with infinite retries. maybe better to dynamically increase the request.maxRetries instead and have some max, e.g. 10
not sure how easy it is to get around those blocking errors just by picking new session/proxy? it sounds safer to not count this into the retry limit
B4nan
approved these changes
Jul 4, 2023
barjin
force-pushed
the
feat/retryOnBlocked
branch
from
3e59336
to
28784f0
Compare
B4nan
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current design implements the
retryOnBlockedfeature in (HTTP | Browser)Crawler. Maybe there is a nicer OOP way to do this?Also, it currently utilizes a very simple (but reasonably robust) way of detecting blocking with CSS selectors for Cloudflare and Google Search antibot feature. We might want to extend this?