Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: got-scraping ESM edition #2110

Merged
merged 2 commits into from Nov 14, 2023
Merged

feat: got-scraping ESM edition #2110

merged 2 commits into from Nov 14, 2023

Conversation

vladfrangu
Copy link
Member

No description provided.

@vladfrangu vladfrangu requested a review from B4nan October 3, 2023 10:09
@github-actions github-actions bot added this to the 73nd sprint - Tooling team milestone Oct 3, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 3, 2023
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 3, 2023
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Oct 3, 2023
.gitignore Outdated Show resolved Hide resolved
test/tsconfig.json Show resolved Hide resolved
@B4nan
Copy link
Member

B4nan commented Nov 8, 2023

Let's rebase and merge this one now I guess?

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i actually forgot to confirm the review :D

chore: mocks, tests, pain

chore: more test fixes

chore: bump linkedom to remove patch

chore: cleanup on isle lockfile

chore: some more fixes on linting and tests

chore: cleanup tsconfigs and lock got-scraping to actual beta version

chore: forgot to actually push this

chore: le lock file 2

chore: remove redundant edits

chore: well someone fixed the bug

chore: le lint

chore: forgot to actually drop beta
@vladfrangu vladfrangu merged commit 2f05ed2 into master Nov 14, 2023
8 checks passed
@vladfrangu vladfrangu deleted the feat/got-scraping-v4 branch November 14, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants