Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides): add 'Running in web server' guide #2543

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

metalwarrior665
Copy link
Member

I took the Parallel Scraping guide as a template so please check that it makes sense. The code/example are really bare bones and there might be some code smells.

I checked that the example works and the text with Grammarly.

Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just curious what the article is about and noticed a typo

docs/guides/running-in-web-server/web-server.mjs Outdated Show resolved Hide resolved
Co-authored-by: Jan Buchar <jan.buchar@apify.com>
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would prefer no gerunds in headings tho

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just two tiny nits

docs/guides/running-in-web-server/web-server.mjs Outdated Show resolved Hide resolved
@B4nan B4nan merged commit 0d1f644 into master Jun 24, 2024
9 checks passed
@B4nan B4nan deleted the docs/running-in-web-server branch June 24, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants