Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apify.launchPuppeteer() now supports proxyUrl with socks4, socks5 and https schemes #425

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Apify.launchPuppeteer() now supports proxyUrl with socks4, socks5 and https schemes #425

merged 4 commits into from
Jul 24, 2019

Conversation

jancurn
Copy link
Member

@jancurn jancurn commented Jul 22, 2019

Fixes #420

@jancurn jancurn requested review from mtrunkat and mnmkng July 22, 2019 20:24
@jancurn jancurn mentioned this pull request Jul 22, 2019
Closed
@mnmkng
Copy link
Member

mnmkng commented Jul 23, 2019

Does it also fix #389 ?

@jancurn
Copy link
Member Author

jancurn commented Jul 23, 2019

Does it also fix #389 ?

Only partially - Socks is supported only if used without authentication.

@mnmkng mnmkng merged commit d63637e into master Jul 24, 2019
@mnmkng mnmkng deleted the fix/anonymize-proxy branch July 24, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrunkat mtrunkat mtrunkat approved these changes

@mnmkng mnmkng mnmkng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to disable anonymizeProxy
3 participants
@jancurn @mnmkng @mtrunkat