Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maybeAddProxyAuthorizationHeader should add password if it is empty #12

Closed
regevbr opened this issue Apr 15, 2018 · 1 comment
Closed

maybeAddProxyAuthorizationHeader should add password if it is empty #12

regevbr opened this issue Apr 15, 2018 · 1 comment

Comments

@regevbr
Copy link
Contributor

regevbr commented Apr 15, 2018

Currently if no password is supplied, the ':' char is not added, causing the base64 of the username/password to be invalid
jancurn added a commit that referenced this issue Apr 15, 2018
@jancurn
Merge pull request #13 from regevbr/master
def457c 
#12 maybeAddProxyAuthorizationHeader should add password if it is empty
@jancurn
Copy link
Member

jancurn commented Apr 15, 2018

Thanks for the PR, it's now merged and published on NPM.

@jancurn jancurn closed this as completed Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@regevbr @jancurn