Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Avoid accessing prototype in custom_connect #522

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

JuroOravec
Copy link
Contributor

See the discussion here: #521 (comment)

NOTE: I tried running npm run test to ensure everything works. But the tests were failing because of other error (below) even before I made the change, so I can't ensure integrity.

$ npm run test

> proxy-chain@2.3.0 test
> nyc cross-env NODE_OPTIONS=--insecure-http-parser mocha --bail



(node:23123) Warning: Using insecure HTTP parsing
(Use `node --trace-warnings ...` to show where the warning was created)
  1) supports localAddress

  0 passing (2s)
  1 failing

  1) supports localAddress:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/presenter/repos/proxy-chain/test/server.js)
      at listOnTimeout (node:internal/timers:557:17)
      at processTimers (node:internal/timers:500:7)

src/custom_connect.ts Outdated Show resolved Hide resolved
@JuroOravec JuroOravec changed the title refactor: Avoid accessing in custom_connect refactor: Avoid accessing prototype in custom_connect Aug 20, 2023
src/custom_connect.ts Outdated Show resolved Hide resolved
@jancurn jancurn merged commit 2cd7c57 into apify:master Aug 21, 2023
4 checks passed
@jancurn
Copy link
Member

jancurn commented Aug 21, 2023

@JuroOravec thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants