Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add option to specify server's host #526

Merged
merged 5 commits into from
Nov 2, 2023
Merged

feat: Add option to specify server's host #526

merged 5 commits into from
Nov 2, 2023

Conversation

jirimoravcik
Copy link
Member

@jirimoravcik jirimoravcik commented Nov 2, 2023 •
edited

I've added support for specifying host used for the listen call. This will enable users to e.g. listen on localhost, which can be more secure than the default unspecified IP address (0.0.0.0).

@jirimoravcik jirimoravcik added adhoc Ad-hoc unplanned task added during the sprint. medium priority Medium priority issues to be done in a couple of sprints. labels Nov 2, 2023
@github-actions github-actions bot added this to the 75th sprint - Platform team milestone Nov 2, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Nov 2, 2023
barjin
barjin approved these changes Nov 2, 2023
View reviewed changes
Copy link

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks :)

jancurn
jancurn reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jirka. Please can we also add a (simple) unit test for the host param?

README.md Outdated Show resolved Hide resolved
@jancurn
Copy link
Member

jancurn commented Nov 2, 2023

Plus, can we please update the anonymizeProxy() function to set localhost? That will increase security by default, plus test the new option

@jirimoravcik jirimoravcik changed the title feat: Add option to specify server's hostname feat: Add option to specify server's host Nov 2, 2023
jancurn
jancurn reviewed Nov 2, 2023
View reviewed changes
src/anonymize_proxy.ts Outdated Show resolved Hide resolved
@jirimoravcik jirimoravcik merged commit 5222782 into master Nov 2, 2023
4 checks passed
@jirimoravcik jirimoravcik deleted the feature/allow-to-specify-hostname-for-listen branch November 2, 2023 11:00
@drobnikj drobnikj added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

@jancurn jancurn jancurn approved these changes

@barjin barjin barjin approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels
adhoc Ad-hoc unplanned task added during the sprint. medium priority Medium priority issues to be done in a couple of sprints. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
75th sprint - Platform team
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jirimoravcik @jancurn @fnesveda @barjin @drobnikj