Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update anonymizeProxy docs #536

Merged
merged 2 commits into from
May 2, 2024

Conversation

jirimoravcik
Copy link
Member

No description provided.

@jirimoravcik jirimoravcik added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 29, 2024
@github-actions github-actions bot added this to the 88th sprint - Platform team milestone Apr 29, 2024
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Apr 29, 2024
Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jirka

@@ -368,7 +368,7 @@ The package also provides several utility functions.

Parses and validates a HTTP proxy URL. If the proxy requires authentication,
then the function starts an open local proxy server that forwards to the proxy.
The port is chosen randomly.
The port (on which the local proxy server will start) can be set via the `port` property of the first argument, if not provided, it will be chosen randomly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you reuse the same port - the old proxy is replaced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if the old local proxy server is running, you'd get e.g. Error: listen EADDRINUSE: address already in use, because the port is already in use. I believe this is a standard error, it's very similar to cases like trying to start local web servers on the same port.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks

github-actions[bot]

This comment was marked as resolved.

@jirimoravcik jirimoravcik merged commit 475a679 into master May 2, 2024
4 checks passed
@jirimoravcik jirimoravcik deleted the docs/update-anonymize-proxy-docs branch May 2, 2024 06:47
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants