Update dependency and add missing istanbul dependency #47
Conversation
|
@IvanGoncharov please review |
| @@ -1,7 +1,9 @@ | |||
| sudo: false | |||
| language: node_js | |||
| script: | |||
| - npm test && npm run coveralls | |||
| - npm test | |||
| - npm run coveralls | |||
There was a problem hiding this comment.
From Travis docs:
When one of the build commands returns a non-zero exit code, the Travis CI build runs the subsequent commands as well, and accumulates the build result.
http://docs.travis-ci.com/user/customizing-the-build/#Customizing-the-Build-Step
So if npm test will fail Travis will try to execute npm run coveralls and it's produce more errors which will make error diagnostic harder.
mohsen1
force-pushed
the
deps
branch
2 times, most recently
from
c58db30
to
f1b099b
Compare
mohsen1
force-pushed
the
deps
branch
2 times, most recently
from
f7d271a
to
1c71554
Compare
|
I just confirmed that it's iojs' new URL module breaking changes that is causing the failure. I'm digging in to see if it's iojs' bug or not. |
|
Ok. I'm currently working on feature that will extend API, we discussed it on Gitter. |
|
IMHO, its better to use https://github.com/medialize/URI.js |
Also fix a test that was breaking due to swagger-tools change and clean up travis.yaml file This also copies over url.js file from nodejs/node to fix compability issues
|
ok @IvanGoncharov that makes sense. Copying over code is never a good idea. I'll merge this. Please make your changes in master after this merge. |
Update dependency and add missing istanbul dependency
Update dependency and add missing istanbul dependency
Also fix a test that was breaking due to swagger-tools change and clean up travis.yaml file