mockModeNoCallback option and controller cache #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockModeNoCallback config option makes it possible for mockMode to behave more like the real deal. swagger examples show res.end() in the controllers while mock mode use cb(). This makes a huge difference for projects using custom fitters after the router.
| cb(new Error(util.format('No controller found for %s in %j', controllerName, controllersDirs))); | ||
| } | ||
| }; | ||
| response.setHeader('Content-Type', mimetype); |
There was a problem hiding this comment.
Can someone please confirm if it's ok to use response.setHeader instead of context.headers[]?
There was a problem hiding this comment.
The best confirmation you'll get is a test that runs this code
options.ignoreMissingHandlers: [boolean] When false (default), a 500 is returned when a handler cannot be found. When true, we will ignore the missing handler and send the request downstream.
|
Thanks for your contribution. Would you be able to provide any tests to verify your work? |
I think it's a deceiving problem, we need to fix these examples. The fact that the examples assume there is no handler down the pipeline after them is not known to readers - hence the deception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see my question about context.headers[] before merging.
after the router.
Sorry for the bundled pull request ;)