[DRUP-803] Prevent installation alongside of the `apigee_edge_apidocs… #7
Conversation
There was a problem hiding this comment.
I just tested this, with Apigee Edge at apigee/apigee-edge-drupal@6cfe266 and it worked great.
@Jaesin If you can make that name change real quick, that would be good...Otherwise, I think this is good to go.
apigee_api_catalog.install
Outdated
| return [ | ||
| 'apigee_api_catalog_module_conflict' => [ | ||
| 'title' => t('Apigee API Catalog'), | ||
| 'description' => t('The "Apigee Edge Apidocs" module is currently installed. It is deprecated and should be uninstalled before installing the Apigee API Catalog module.'), |
There was a problem hiding this comment.
Would be good to name this the same way the module does.
- 'description' => t('The "Apigee Edge Apidocs" module is currently installed. It is deprecated and should be uninstalled before installing the Apigee API Catalog module.'),
+ 'description' => t('The "Apigee Edge API Docs" module is currently installed. It is deprecated and should be uninstalled before installing the Apigee API Catalog module.'),
There was a problem hiding this comment.
Thanks. I pushed a fix for this.
|
I'm testing out @arshad's patch at apigee/apigee-devportal-kickstart-drupal#114, while still on this branch (with apigee edge apidocs still) and this is what I'm seeing:
|
|
Nice catch. I just pushed what I hope will fix that. |
|
That fixed it! Thanks! 👍 |
|
The scenario that hasn't' been tested at this point is trying to install the |
|
I installed drush 9 and it really has no respect for Should we work on figuring out a workaround for this? |
|
I added separate issue #10 so we can accept this PR w/out dealing w/Drush. |
|
Fixes: #5 |
…` module.