-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for symfony 6.2 upgrade #262
Changes for symfony 6.2 upgrade #262
Conversation
Codecov Report
@@ Coverage Diff @@
## drupal10-prep #262 +/- ##
===================================================
- Coverage 89.16% 88.64% -0.53%
Complexity 1649 1649
===================================================
Files 330 330
Lines 4373 4375 +2
===================================================
- Hits 3899 3878 -21
- Misses 474 497 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can somebody also reference all those issues from https://github.com/apigee/apigee-client-php/issues?q=is%3Aissue+is%3Aopen+label%3A%22Drupal+10+Preparation%22 that this PR resolves? I am asking because we were planning to contribute to D10 prep tasks, but we do not see clearly what is in WIP state already and where help is needed. |
@mxr576 , Thank you so much for offering help. We really appreciate it. This PR resolves the issue that we were facing while upgrading to symfony 6.2. |
Opened a follow up issue regarding the merged changes: #269
Thanks, that is not too many :) Can some of these closed also? |
* Http\Client\HttpClient deprecated used Psr\Http\Client\ClientInterface (#261) (#263) Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com> * Fix for setIgnoredAttributes() method is deprecated (#238) * Changes for symfony 6.2 upgrade (#262) * Bumped minimum symfony/serializer version to 6.2 (#272) * bump symfony/serializer * typo fix --------- Co-authored-by: Gitesh Koli <giteshk@users.noreply.github.com> Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com>
Fix for errors when symfony is upgraded to 6.2.
Fixes #254