Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for symfony 6.2 upgrade #262

Merged
merged 13 commits into from
May 30, 2023

Conversation

divya-intelli
Copy link
Collaborator

@divya-intelli divya-intelli commented May 16, 2023

Fix for errors when symfony is upgraded to 6.2.
Fixes #254

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #262 (cdb9894) into drupal10-prep (29a0110) will decrease coverage by 0.53%.
The diff coverage is 73.61%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             drupal10-prep     #262      +/-   ##
===================================================
- Coverage            89.16%   88.64%   -0.53%     
  Complexity            1649     1649              
===================================================
  Files                  330      330              
  Lines                 4373     4375       +2     
===================================================
- Hits                  3899     3878      -21     
- Misses                 474      497      +23     
Flag Coverage Δ
unittests 88.64% <73.61%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Denormalizer/ObjectDenormalizer.php 96.87% <ø> (-0.10%) ⬇️
src/Exception/ApiException.php 0.00% <0.00%> (ø)
src/Exception/ApiRequestException.php 26.66% <0.00%> (ø)
src/Exception/ApiResponseException.php 71.11% <0.00%> (ø)
src/Exception/CpsNotEnabledException.php 0.00% <0.00%> (ø)
src/Exception/InvalidJsonException.php 42.85% <0.00%> (ø)
...Client/Plugin/Authentication/GceServiceAccount.php 0.00% <0.00%> (ø)
src/Normalizer/CredentialProductNormalizer.php 25.00% <0.00%> (-3.58%) ⬇️
.../Management/Controller/AppCredentialController.php 40.24% <50.00%> (ø)
...i/Monetization/Builder/RatePlanRevisionBuilder.php 95.45% <50.00%> (-4.55%) ⬇️
... and 22 more

... and 1 file with indirect coverage changes

@divya-intelli divya-intelli marked this pull request as ready for review May 30, 2023 09:18
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxr576
Copy link
Contributor

mxr576 commented May 30, 2023

Can somebody also reference all those issues from https://github.com/apigee/apigee-client-php/issues?q=is%3Aissue+is%3Aopen+label%3A%22Drupal+10+Preparation%22 that this PR resolves?

I am asking because we were planning to contribute to D10 prep tasks, but we do not see clearly what is in WIP state already and where help is needed.

@divya-intelli
Copy link
Collaborator Author

@mxr576 ,

Thank you so much for offering help. We really appreciate it.

This PR resolves the issue that we were facing while upgrading to symfony 6.2.
After merging this PR we will update the Drupal modules to support Drupal 10.
We have also marked the tickets which we need help with tag "help wanted".

@divya-intelli divya-intelli merged commit 5e4def5 into apigee:drupal10-prep May 30, 2023
5 of 6 checks passed
@mxr576
Copy link
Contributor

mxr576 commented May 30, 2023

Opened a follow up issue regarding the merged changes: #269

We have also marked the tickets which we need help with tag "help wanted".

Thanks, that is not too many :)

Can some of these closed also?
https://github.com/apigee/apigee-client-php/issues?q=is%3Aissue+is%3Aopen+label%3A%22Drupal+10+Preparation%22

divya-intelli added a commit that referenced this pull request Jun 22, 2023
* Http\Client\HttpClient deprecated used Psr\Http\Client\ClientInterface (#261) (#263)

Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com>

* Fix for setIgnoredAttributes() method is deprecated (#238)

* Changes for symfony 6.2 upgrade (#262)

* Bumped minimum symfony/serializer version to 6.2 (#272)

* bump symfony/serializer

* typo fix

---------

Co-authored-by: Gitesh Koli <giteshk@users.noreply.github.com>
Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com>
@divya-intelli divya-intelli modified the milestones: 2.1.1, 3.0.0 Jun 29, 2023
@divya-intelli divya-intelli added this to In progress in Drupal-based Development Board via automation Jun 29, 2023
@divya-intelli divya-intelli added the enhancement New feature or request label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants