Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented AppGroup membership feature #268

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Implemented AppGroup membership feature,
All the member details (email id and roles) would be stored in database and AppGroup's _apigee_reserved__memberships attribute as well.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #268 (b7969dd) into appgroup (1bdb687) will decrease coverage by 1.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             appgroup     #268      +/-   ##
==============================================
- Coverage       86.51%   85.22%   -1.29%     
- Complexity       1693     1718      +25     
==============================================
  Files             340      345       +5     
  Lines            4508     4576      +68     
==============================================
  Hits             3900     3900              
- Misses            608      676      +68     
Flag Coverage Δ
unittests 85.22% <0.00%> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/ApigeeX/Controller/AppGroupMembersController.php 0.00% <0.00%> (ø)
...eX/Denormalizer/AppGroupMembershipDenormalizer.php 0.00% <0.00%> (ø)
...pigeeX/Normalizer/AppGroupMembershipNormalizer.php 0.00% <0.00%> (ø)
...pigeeX/Serializer/AppGroupMembershipSerializer.php 0.00% <0.00%> (ø)
src/Api/ApigeeX/Structure/AppGroupMembership.php 0.00% <0.00%> (ø)

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 9f9e6f9 into apigee:appgroup Jun 13, 2023
7 of 8 checks passed
@shishir-intelli shishir-intelli added the enhancement New feature or request label Jun 21, 2023
@shishir-intelli shishir-intelli added this to In progress in Drupal-based Development Board via automation Jun 21, 2023
@shishir-intelli shishir-intelli added this to the 2.1.0 milestone Jun 21, 2023
@shishir-intelli shishir-intelli deleted the appgroup-membership branch July 6, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants